Björn Harrtell comments

Results 203 comments of


Björn Harrtell

[TS] Add generated content to repo to track future changes

Strange.. CI complains with: ``` Run scripts/check_generate_code.py diff --git a/tests/optional-scalars/scalar-stuff.ts b/tests/optional-scalars/scalar-stuff.ts index 6b70ded..a7[4](https://github.com/google/flatbuffers/runs/7566214476?check_suite_focus=true#step:4:5)8c22 100[6](https://github.com/google/flatbuffers/runs/7566214476?check_suite_focus=true#step:4:7)44 --- a/tests/optional-scalars/scalar-stuff.ts +++ b/tests/optional-scalars/scalar-stuff.ts @@ -20[7](https://github.com/google/flatbuffers/runs/7566214476?check_suite_focus=true#step:4:8),10 +207,6 @@ defaultEnum():OptionalByte { return offset ? this.bb!.readInt[8](https://github.com/google/flatbuffers/runs/7566214476?check_suite_focus=true#step:4:9)(this.bb_pos + offset)...

[TS] Add generated content to repo to track future changes

Looks like it was due to different gen options for tests vs ./scripts/generate_code.py. Hopefully fixed in additional commit.

[TS] Add generated content to repo to track future changes

This may look like alot of redundant content but I do believe it provides value to be able to see/detect future changes affecting generation. And AFAIK for other langs we...

[TS] Add generated content to repo to track future changes

@aardappel I agree and I cannot find any evidence of them actually being exercised in tests but I assume there is a sensible reason for why they were added, perhaps...

[TS] Add generated content to repo to track future changes

Thanks @jameskuszmaul-brt, that makes sense to me.

[TS] Regression in generating from simple schema

@domoritz would like to but unlikely to be able to prioritize this in near future. You are welcome to work on it yourself.

no exported member ``Long``

Long has been removed entirely and replaced with native BigInt support. See https://github.com/google/flatbuffers/pull/6998. This change deserved more than a patch level bump, which I wrote at https://github.com/google/flatbuffers/pull/6998#discussion_r779611994. I can however...