Benoit Jacob

Results 144 comments of Benoit Jacob

@MaheshRavishankar : 1. Is the WORKSPACE file still needed? 2. Was either https://bazel.build/external/migration_tool or https://github.com/bazelbuild/bazel-central-registry/tree/main/tools/code-agent used? Just trying to gauge what is bespoke vs standard in this migration.

@benvanik , one thing that I noticed was that `IREE_IO_FILE_MAPPING_FLAG_PRIVATE` was missing in a couple places. Worth taking separately ?

Oh I see it's a transparent issue in the source code - I had wrongly assumed that it would be something mysterious that I couldn't investigate on my own.

Why wasn't this merged? @Muzammiluddin-Syed-ECE has done something similar again in https://github.com/iree-org/iree/pull/22780.