Bit Planets comments

Results 22 comments of


                                            Bit Planets

use module.exports to export your module for npm

Is not to use on the server side, but is to keep the window namespace clean. If I provide a module.export or define, you should export your module to that....

Made background transparent, added resize to prototype

I think would be useful for others.

List of features we want to implement

You also need to add `extensions: ['', '.js', '.json'],` to your webpack config. I'm also having problems on node.js... Not easy to fix.

Fix #6 Now you can also return value from define function like can be done with require.js

@sokra Please merge this and add publish to npm. Thanks

Fix #6 Now you can also return value from define function like can be done with require.js

No because is easier for some function to return something by mistake, than set a property on exports variable. Ok, I will try to make a test (:

Fix #6 Now you can also return value from define function like can be done with require.js

@sokra Added the tests

Fix #6 Now you can also return value from define function like can be done with require.js

@sokra Added, also allows to return falsy values.

Fix #6 Now you can also return value from define function like can be done with require.js

Ok, I've made the changes.

Amd module with return doesn't get populated on node.js

Here https://github.com/webpack/enhanced-require/blob/master/lib/RequireContext.js#L344 instead of: ``` fn(reqFn, parent.exports, parent); ``` should be ``` parent.exports = fn(reqFn, parent.exports, parent); ``` Or something more specific, like only replacing if no value is set...

doesn't support emitFile

+1 when you need server-side rendering you need image urls.