R. David Murray comments

Results 38 comments of


                                            R. David Murray

Improve clarity of signal.siginterrupt docs

The first phase says "restarted when interrupted", the second phrase says "interrupted". So the difference is whether the system call is restarted or left in interrupted state (ie: the signal...

sys.exit() caught in async event loop exception handler

I expected this function to be parallel to sys.excepthook, but I see that sys.excepthook does not get called if you call sys.exit() at the python prompt. So I guess I...

sys.exit() caught in async event loop exception handler

Ah, I misunderstood your report, because I didn't actually run the example. The exception is being ignored because it is raised during a \_\_del__ method execution. This has nothing to...

sys.exit() caught in async event loop exception handler

So, any exception raised in the exception handler will be re-raised via call_soon. I think the message would be clearer if it said that (that the exception comes from the...

sys.exit() caught in async event loop exception handler

No, you are talking about \*all* exceptions, since they all descend from BaseException. Python's normal \_\_del__ handling just prints the ignored exception to stdout, even if it is a BaseException....

sys.exit() caught in async event loop exception handler

Not until you convince me there is a reason for deviating from Python's normal \_\_del__ handling :) (Or other asyncio developers agree with you and not me.)

sys.exit() caught in async event loop exception handler

Using sys.exit means you are depending on garbage collection to clean up all of your program's resources. In the general case this is a bad idea. A better design is...

Adding the ability for getpass to print asterisks when password is typed

getpass is emulating the unix password prompt behavior. I'm not sure if the complication is worth it, especially since not echoing asterisks is, as you observe, fractionally more secure. So...

tarfile: Traversal attack vulnerability

Note that any issues here should also be considered for zipfile and shutil. (Well, shutil can just use the other two once the security is available.) See bpo-20907.

argparse: document that add_argument returns a Action object

Can you provide some specific use cases, please?