secp256k1

secp256k1 copied to clipboard

Add a libFuzzer fuzzing harness

18

Hi, As a result of #739, I wrote a fuzzing harness so people can fuzz the library themselves if they want so. This is my first time playing with libFuzzer...

elichai

Add simple static checker based on clang-query

13

This add a simple static checker based on clang-query, which is a tool that could be described as a "clever grep" for abstract syntax trees (ASTs). As an initial proof...

real-or-random

Document / assert non-portable assumptions

9

> I think it's reasonable to require a two's complement implementation (we could verify it in a configure script, and in unit tests) If you really have some exotic system,...

real-or-random

Use blinded instead of constant time inverse in secret gej->ge?

6

Currently the conversion from projective to affine in pubkey creation, signing, and ECDH use a constant time ladder inverse because the z value conceivably leaks information. This applies even in...

gmaxwell

ULL constants are not C89

1

The README states as a goal: "Intended to be portable to any system with a C89 compiler and uint64_t support." The C89 syntax does not specify `unsigned long long` (`ULL`)...

real-or-random

Summarize currently implemented optimizations

3

Documenting the optimizations in this library would help the coming generations of contributors. A few things are already mentioned in the README's "Implementation details". Perhaps it would make sense to...

jonasnick

Better randomness test for secp256k1_rand_bits

8

sipa

API/docs: Return value if ARG_CHECK fires

6

For some functions handling public keys, the API docs claim that these functions always return 1. But when a zeroed pubkey is passed, the ARG_CHECK fires and they return 0....

real-or-random

Provide pkg-config packages for optional modules

11

This makes it way easier for dependent projects to probe whether libsecp256k1 was built with an optional module they might require. Fixes #666

ysangkok

Experimental features should be deprecated

14

If a feature is genuinely experimental, keep it in a separate branch. Otherwise, it *will* be compiled in, as there may be a user. This becomes inevitable in larger systems:...

rustyrussell