secp256k1

secp256k1 copied to clipboard

(Description partly copied from https://github.com/bitcoin-core/secp256k1/pull/1512#issuecomment-2045254282) The default of what is considered a "use" of uninitialized memory was changed in clang 16. Returning an uninitialized variables from a function, or passing...

real-or-random

doc: Add convention for defaults

1

Resolves #1549. This does not say anything about compiler options and the like, but I think that's okay for now.

real-or-random

This ports over the work from b-wagn in https://github.com/BlockstreamResearch/secp256k1-zkp/pull/261 In the second commit I have [addressed the follow-ups](https://github.com/BlockstreamResearch/secp256k1-zkp/issues/291) though I was not always sure if I understood them correctly since...

fjahr

cmake: Rework flags summary

7

This was requested in https://github.com/hebasto/bitcoin/issues/221. The implementation follows the same approach as in https://github.com/hebasto/bitcoin/pull/93. Here are a few excerpts from the summaries: - Linux: ``` Cross compiling ....................... FALSE Valgrind...

hebasto

tests: Lower default of iters to 4 (but keep higher on CI)

4

See discussion at https://gnusha.org/secp256k1/2024-07-01.log, also mentioned in https://github.com/bitcoin-core/secp256k1/issues/1549.

real-or-random

discussion: Config used by Core vs defaults and config in CI/testing

5

Quoting myself from https://github.com/bitcoin-core/secp256k1/issues/1543#issuecomment-2176914205: > I believe we want to build libsecp256k1 with the default `RelWithDebInfo` (`-O2 -g` in our case) even when we build it as part of Core....

real-or-random

See discussions here: - https://gnusha.org/secp256k1/2024-07-01.log - https://github.com/bitcoin-core/secp256k1/issues/1549 We want to exclude problematic platforms to address the concerns in https://github.com/bitcoin-core/secp256k1/pull/723 . Rare platforms that were problematic in the past are -...

real-or-random

cmake: Add `--no-undefined` linker option

6

This PR adds the `--no-undefined` option to a linker, which supports it. From the GNU ld [docs](https://sourceware.org/binutils/docs/ld.html): > `--no-undefined` > > Report unresolved symbol references from regular object files. This...

hebasto

Is default `-Wl,--no-undefined` desired?

1

Consider the following diff: ```diff --- a/src/secp256k1.c +++ b/src/secp256k1.c @@ -765,7 +765,9 @@ int secp256k1_ec_pubkey_tweak_mul(const secp256k1_context* ctx, secp256k1_pubkey return ret; } +void undefined_function(void); int secp256k1_context_randomize(secp256k1_context* ctx, const unsigned char *seed32)...

hebasto

cmake: Clean up testing code

2

1. Delete `CTest` module. The `CTest` module handles `CDash` integration, which we do not use. It is not required for testing functionality. 2. Clean up cases when to invoke `enable_testing()`...

hebasto