Gautam Bisht
Gautam Bisht
@daleihao After renaming the test, you also need to move: `components/elm/cime_config/testdefs/testmods_dirs/elm/snicar_ad_improve/user_nl_elm` to `components/elm/cime_config/testdefs/testmods_dirs/elm/koch_snowflake/user_nl_elm`.
@peterdschwartz This PR looks ready to be merged. Can you please review this PR?
@peterdschwartz I have now uploaded the missing file on https://web.lcrc.anl.gov/public/e3sm/inputdata/lnd/clm2/snicardata/.
@sshu88 You have mistakenly updated multiple submodules in this PR which need to be reverted.
@sshu88 Thanks for fixing the submodules. Is this PR still WIP or ready to be reviewed/merged or waiting for another FATES PR to go first? cc: @glemieux @rgknox
@sshu88 Is this WIP or ready to be merged?
Are the existing tests cover the new physics? Or, should we add a new test?
The `ERS.ne30pg2_r05_EC30to60E2r2.GPMPAS-JRA.compy_intel.mosart-rof_ocn_2way` failed related to ``` MCT::m_AttrVect::indexRA_:: FATAL--attribute not found: "Flrl_inundinf" Traceback ``` I'm debugging this error today and will keep you updated.
I had incorrectly resolved the conflicts in `driver-mct/main/prep_rof_mod.F90` that caused the `ERS.ne30pg2_r05_EC30to60E2r2.GPMPAS-JRA.compy_intel.mosart-rof_ocn_2way` test to fail. After correctly resolving the conflict, the test passes.
@liho745 I merged your branch to next locally on Compy and ran e3sm_land_developer tests. All tests failed and I believe it is because of your recent commit ([71da40a](https://github.com/E3SM-Project/E3SM/pull/5103/commits/71da40aec9726b119856e721b609811145be6cab)). Can you...