Gregor Lenz

Results 66 comments of Gregor Lenz

That's a good point, thanks for flagging that! For a quick workaround I just used custom wrapper functions in the past

@fedebecat I'm happy to change the reference to the original paper, could you please open a PR for that?

Thanks for chiming in @Barchid . Then @fedebecat if you could change the implementation, the name and the reference in a PR that would be great. For the moment we'll...

This is a very good point, thanks a lot for the detailed explanation. So what are the use cases that should be covered? 1. Binning time windows needs 3 out...

we could re-use this transform for it by providing a slice_time parameter, it currently only subtracts the first timestamp, which aimed to solve a related problem https://tonic.readthedocs.io/en/latest/generated/tonic.transforms.TimeAlignment.html#tonic.transforms.TimeAlignment

Or we are even cleverer and provide and option to make SliceByTime subtract the slice_time during slicing itself. It needs to be optional though, this might not always be desired

we could have a reset_timestamps parameter in here https://tonic.readthedocs.io/en/latest/_modules/tonic/slicers.html#SliceByTime

Hello @MinaKh! Currently I don't understand how what you're trying to achieve with this class cannot already be done with existing classes. It seems to me that you want to...

thanks for reporting this. Should we bring it back? Not sure it still works though https://github.com/neuromorphs/tonic/blob/35f6118850abf7e63b32667f519f0b6f65e68450/tonic/download_utils.py#L120C1-L170C1