tonic
tonic copied to clipboard
download_utils: Function definition missing for downloading from Google drive
The function download_url
in the download_utils
module attempts to call a function download_file_from_google_drive
, which is not defined, see here.
thanks for reporting this. Should we bring it back? Not sure it still works though
https://github.com/neuromorphs/tonic/blob/35f6118850abf7e63b32667f519f0b6f65e68450/tonic/download_utils.py#L120C1-L170C1
Usually with the drive stuff it is better if the user does it manually like with Prophesee stuff?
Yeah I see your pont. I just tried the function from torchvision and at least for the dataset I'm looking at it fails without any warning.
Then maybe it's better instead to produce an error message, saying that data from google drives should be downloaded manually?
yes agreed!
There is also a function from torchdata, but since its development is paused, it is better to provide an error message. What do you think?
I think that makes total sense. Let the user download it manually for now
Just tried out https://github.com/wkentaro/gdown/tree/main and it works super well. Should switch to that for Gdrive