Refactor _keepUniqueKeys

Open ElDeveloper opened this issue 5 years ago • 2 comments

This should add a nice speed boost.

Mar 29 '20 00:03 ElDeveloper

Looking through the code, it looks like _keepUniqueKeys() actually doesn't depend on the state of Empress -- it doesn't use any this references or anything. We may be able to move it to a separate module and/or unit-test it now, which would help a lot when refactoring it. (Also I suspect that this function might be the cause of #152.)

Apr 06 '20 19:04 fedarko

I can take this one

Oct 20 '20 16:10 gwarmstrong