biom-format icon indicating copy to clipboard operation
biom-format copied to clipboard

align_tree cannot handle features with 0 counts

Open dpear opened this issue 10 months ago • 2 comments

if a feature table has a feature with 0 sum, align_tree will throw an error stating that the id of the feature is not present in the table. (apologies for brevity, let me know and I can follow up with code examples etc.)

dpear avatar Mar 29 '24 17:03 dpear

Hi, did you try this workaround : https://github.com/biocore/biom-format/issues/860 As @wasade and I discussed in previous iterations, if we explicitly store zeros in the biom table, it sort of thwarts bioms' ability to have memory efficient storage.

mortonjt avatar Apr 02 '24 14:04 mortonjt

Thanks, @mortonjt! But there is an edge case here that needs to be fixed. sort_order based off the tree, but called after remove_empty which will raise if a feature is removed.

wasade avatar Apr 02 '24 15:04 wasade

Fixed in #959, unsure why it didn't automatically close.

wasade avatar May 02 '24 15:05 wasade