791 type hints

[anju24]

Relates to #791

[github-actions[bot]]

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 30 days.

[davmlaw]

I kept the logic changes in main (for uncertainty), while keeping typing changes from 791-type-hints

I think I messed up my git origin so will put this on my own repo/branch then pull request into anju24's repo branch to update pull request

There were a few issues with the type hints:

normalizer.py - boundary can return float('inf') not just tuple[int, int] as can _get_tgt_length so just removed those annotations

validator.py - Changed strict: bool = None to strict: bool | None = None. Line 86 - validate(var: bool = None) was wrong (should have been var: SequenceVariant)

variant mapper - used "hgvs.intervalmapper.Interval" - I don't think it should have been this one (there are 2) - deleted it

[davmlaw]

I pushed to wrong place and it ended up in this repo's branch: https://github.com/biocommons/hgvs/tree/791-type-hints

Changes vs main: https://github.com/biocommons/hgvs/compare/main...791-type-hints

I was able to fix conflicts with main, though when I tried to get it back onto @anju24 pull request, it still ends up with merge conflicts. I suspect this may be due to the auto formatting?

Perhaps it would be easier to make a new pull request from that other branch?

[github-actions[bot]]

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 30 days.