hgvs icon indicating copy to clipboard operation
hgvs copied to clipboard

Add support for pulling from seqrepo-rest-service.

Open andreasprlic opened this issue 3 years ago • 6 comments

Summary It would be nice to be able to connect hgvs to pull sequence data from an instance of seqrepo-rest-service, rather than a local copy of the data (or NCBI). Happy to provide a PR for that.

Implementation Sketch:

Make the vrs-python data proxy more re-usable. Where is the best location for this? Should this be directly in seqrepo? Alternatively, this could also reside in bioutils. Any recommendations? (otherwise I'll just create a PR in seqrepo for this), and then a PR in hgvs to update the SeqFetcher to use this new proxy as a 3rd mechanism for sequence access.

andreasprlic avatar Oct 29 '21 22:10 andreasprlic

@andreasprlic Awesome that you're working on this. It's been needed for a long time. (See #199)

Architectural question: Would it be better (and do we have time) to implement something more like seqrepo-rest-service as a biocommons-rest-service, which would encapsulate UTA and seqrepo? hgvs would then need a new biocommons-rest data provider. And, we'd have to replumb hgvs to standardize responses from both sources. I think this route is better, but also larger, which is why I haven't done it. :-/

reece avatar Nov 01 '21 06:11 reece

@reece yes I totally agree. It would be better to have a service layer also on top of UTA. Having said that, I don't think I have time right now to work on that. Perhaps we should write this up as a ticket (or an epic).

In the meanwhile I was hoping that https://github.com/biocommons/biocommons.seqrepo/pull/98 could be a first step in the right direction.

andreasprlic avatar Nov 01 '21 15:11 andreasprlic

Would it be better (and do we have time) to implement something more like...

@reece - andreas created this github issue after a conversation he & i had about how a requirement has arisen at Invitae with a project i'm working on that requires this now, and ultimately may be of use architecturally for future projects at Invitae.

i intend to investigate what can be done right now to satisfy the immediate need, unless y'all object

bmrobin avatar Nov 09 '21 17:11 bmrobin

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Dec 10 '23 01:12 github-actions[bot]

This issue was closed because it has been stalled for 7 days with no activity.

github-actions[bot] avatar Dec 18 '23 01:12 github-actions[bot]

This issue was closed by stalebot. It has been reopened to give more time for community review. See biocommons coding guidelines for stale issue and pull request policies. This resurrection is expected to be a one-time event.

reece avatar Feb 19 '24 17:02 reece