hgvs icon indicating copy to clipboard operation
hgvs copied to clipboard

hgvs requires pysam via seqrepo; dependency should be optional

Open khmccurdy opened this issue 7 years ago • 4 comments

In my brief research, I came across a pysam fork designed to run on Windows: https://pypi.org/project/pysam-win/ (in reference to #470 ) I have not had the opportunity to test it yet, and likely will not have the ability to compare the two libraries myself, but I believe this may be worth investigating in the interest of expanding OS compatibility.

khmccurdy avatar Sep 20 '18 17:09 khmccurdy

Thanks, Kevin.

There are two things going on here. pysam is getting pulled in by seqrepo, which really should be optional (#523).

The second is issue you've identified regarding pysam on windows. Given that the challenge is really with seqrepo, would you please create a new issue in that repo, reference it in this hgvs issue, and then close it here?

Thanks!

reece avatar Sep 20 '18 17:09 reece

Issue moved to https://github.com/biocommons/biocommons.seqrepo/issues/32.

khmccurdy avatar Sep 20 '18 18:09 khmccurdy

Status: hgvs currently requires seqrepo, which in turn requires pysam. That means that it's impossible to install hgvs without installing pysam.

Plan: make seqrepo optional in hgvs (with extras_require). This will create a breaking change because current users of hgvs with seqrepo will now have to specify seqrepo manually on installation.

reece avatar Oct 21 '18 14:10 reece

If it works within the confines of a setup program, Python has the ability to check which OS it's running in. Maybe the setup could consider seqrepo required or optional depending on whether it's on Windows?

khmccurdy avatar Oct 21 '18 17:10 khmccurdy

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Feb 26 '24 01:02 github-actions[bot]

This issue was closed because it has been stalled for 7 days with no activity.

github-actions[bot] avatar Mar 05 '24 01:03 github-actions[bot]