Daniel Chao comments

Results 256 comments of


                                            Daniel Chao

codegen-java/kotlin: Support generating sealed classes

Yeah; I think that's right

codegen-java/kotlin: Support generating sealed classes

I'm okay with that! @stackoverflow, @holzensp: thoughts?

Amending an undefined property via `super` member access always amends `new Dynamic {}`

We definitely want to improve this, but it's not as simple as "lookup on a `Typed` should fail". A module is also a `Typed`, and this syntax should still work:...

Allow to Mock Resource in testing

I have the same advice that I did in the discussion that @StefMa linked to. The best way to stub out that value is to expose it as an API,...

Add external reader support in pkl-gradle

@HT154 can we add some test coverage for this? I think this would involve moving `TestExternalReaderProcess` to pkl-commons-test, and adding a corresponding test to `org.pkl.gradle.EvaluatorsTest`. Hint: the Groovy syntax for...

Add properties and methods to `Mapping`/`Listing` API to resemble `Map`/`List` more

> While we are here, what is the reason that pkl has Mappings and Map and Listing and List? Several reasons (not comprehensive): * Mapping and Listing are values of...

`is` operator does not take current scope into account

`is` accepts a type, rather than an expression, and types and values exist in different namespaces. This is intentional, and changing this would be a breaking change for how `is`...

`is` operator does not take current scope into account

You can compare the class values directly, e.g. ```pkl import "pkl:reflect" class Foo {} local classes = new Listing { Foo }.toList() function isClassOrSubclass(value: Any, clazz: Class?) = if (clazz...

`is` operator does not take current scope into account

I'm open to it! Feel free to submit a PR for it. Maybe `hasInstance` is a better name.

Language tutorial "Writing a Template" is confusing sometimes

Thanks for the feedback! We'll look to improve the tutorial. But, also, feel free to submit a pull request with changes that you think would be more helpful.