Daniel Chao

Results 256 comments of Daniel Chao

Thanks for the PR! FYI: I probably won't get around to reviewing this until after our 0.26 release is out in early June.

I've tried many times to look for a schema, but as far as I can tell, there's no real schema for JUnit reports. And, the many tools that create JUnit...

Apologies for dropping the ball here! It's not an excuse, but the LSP work has sucked all my attention. I think your revised output looks pretty good! There's some merge...

Follow-up PR: https://github.com/apple/pkl/pull/738

Thanks for the PR! Sorry it took so long to address this. This PR is a little large, but, I'm going to pick of some of these improvements into smaller...

Hey Carpe, thanks for the PR! I don't know if this is the right solution to the problem. As far as I can tell, there is no agreed upon protocol...

I think we should add the check to the `org.pkl.core.module.ModuleKeys#file` factory method; this is the entrypoint for all file-based modules. This is a pattern that we already have! Take a...

I don't think we will support a leading `v`, because that leads to ambiguous situations (what do you do if there is both v1.0.0 and 1.0.0?) Your workaround seems like...

> Maybe “In a strict sense, Pkl does not have functions.” Not totally sure what this means. Do you mean to express that functions in Pkl have `this` as a...