Brian Ingenito

Results 16 comments of Brian Ingenito

Brian Ingenito / Morgan Stanley :wave:

continuous-integration/travis-ci/pr is the old travis-ci.org. I've removed the webhook after I noticed it in the PR.

@Brookke Agreed on prettier. No real preference on spaces of 2 versus 4. Let's encapsulate within here first and then look to split to another repository based on some of...

I can PR this but wanted to open for discussion first before surprise!

@amio Using embed and object tags to embed svg within a page allows for more advanced svg. ``` ``` This includes providing an icon via a url and not svg,...

@kriswest Confirmed I can see your changes in local hosted site. We will need to add support for csharp to the docusaurus config (it isn't on by default). ![image](https://github.com/finos/FDC3/assets/28159742/e67cee54-5d81-4fcc-a778-7892d7524e66)

Here we go. I think you can close this PR if you want and we can continue working on this branch in tandem to create eventual PR. ![image](https://github.com/finos/FDC3/assets/28159742/3bcec6f2-2792-4fe9-98a4-2ee68ba6b4e6)

@kriswest I don't have permission to push to this branch. Do you want me to do my contribution through a PR to this branch and then we PR to master...

I'm fine with either way. If it remains SHOULD and I required it on the handler I would simply ignore if undefined | null.

Does this need to be explicitly removed from markdown too? https://github.com/finos/FDC3/blob/master/docs/api/ref/Metadata.md?plain=1#L324