Bindi Pankhudi
Bindi Pankhudi
> Small changes suggested, but nothing critical. Ready to approve after review of comments/suggestions inline. > > cc @bindipankhudi, @rschwabco All suggested changes have been addressed.
> This is great. One suggestion - which is totally optional - but I think we can use a built-in env var Rather than declaring a new one. This should...
@aaronsteers, addressed the review feedback. We are using built-in pytest env variable now, and also checking the CI env variable.
This issue is dependent on [#225](https://github.com/airbytehq/PyAirbyte/issues/225)
@aaronsteers PR is ready for another look. * I added all proposed minor updates (type hint, etc) * Created this new ticket (https://github.com/airbytehq/airbyte-internal-issues/issues/7917) for updating how we do writes curently....
When the same stream name exists in multiple source, things don't work. For instance, in this notepad: https://colab.research.google.com/drive/197-utzu1I0iMd5Gua0tyFUL2Gu_LFws1?usp=shari we are using source-faker and source-github both of which have "users" schema....
Let's see if we can fail with an accurate message.
De-prioritizing an removing iteration label for now. We will prioritize this if we hear related requests from customers.
Finished taking a pass at the code. The refactoring is easy to follow and makes sense to me. It is def much more intuitive and cleaner to have a separate...
Moving to backlog.