Results 75 comments of Jono M

@romitg2 Just merged the widgets PR, could you update this one?

Ah, could you post a screencast of how it looks logged out as well?

Someone will get to this eventually, we have a bit of a backlog at the moment 😓 We may look at this in a livestream, feels like a good candidate...

I actually wonder if the right fix is to remove `wait_for_ajax` - it's possible that gets stuck on a long-running request and the alert is already dismissed by the time...

Why remove `within`? That should wait already (and looks like our default max wait time is 25 seconds) I think we can literally just remove `wait_for_ajax` and rely on the...

I played around with this locally and discovered just removing `wait_for_ajax` doesn't work. Instead I found another issue that might be related, so will close this in favour of https://github.com/antiwork/gumroad/pull/2615....

The merged PR is a huge improvement (thanks @4arjun!) - the page now loads in a reasonably short time without crashing, at least for me. Clicking any file (e.g. selecting...

Sorry why do we need backward compatibility? (it shouldn't cause problems in production if we change the email parameter behaviour)