Jono M
I believe it’s not deployed due to the Black Friday freeze, will confirm when it is
Sorry for the wait, will hopefully get to this tomorrow
Thanks for the reminder and the contribution!
Ended up just renaming public_url to presigned_url for simplicity, see: https://github.com/antiwork/gumroad/commit/7459983da89ab449ef624d9989fada45c9321237 In general we shouldn't have conditionals in specs; if we want to test multiple configurations (e.g. MinIO vs CloudFront)...
Are there any other erb files? API is being migrated to React as part of the Inertia migration (https://github.com/antiwork/gumroad/pull/2422 cc @romitg2) so we can definitely just inline classes for now
Could you list them? Easier for me to check and useful to have as a record
Ah that's quite annoying, all those little pages don't really need to be React but it's a lot of styles to duplicate. Maybe the best thing is to get this...
Please leave the ERB and SCSS as is for the next PR, let's not inline anything just now. Let me know when the TSX is ready to review
More than 100 lines is fine for migration PRs. And/or you can add `tailwind-override` classes if it's useful to avoid style clashes (there are a couple of examples)
Each PR should (ideally) be testable so for example it should add the component and use it in some example places