Patrick Quinn

Poor Vault choices

1

I was playing around with Vault today and noticed two poor choices. The following scenarios demonstrate the problem: Scenario 1: I have a Vault, two Golds, a Silver, and an...

AI spends too much time evaluating impossible actions

4

I've been profiling the simulator. Web stuff aside, a very large amount of time is being spent in chooseByPriorityAndValue, particularly when it calls actionPriority. actionPriority ends up evaluating the relative...

React with Secret Chamber; draw a reaction card

1

The player should be able to draw a reaction card using Secret Chamber and subsequently react with that card. We don't currently handle this. Simultaneously, the player needs to be...

The AI should be more careful about which treasures it chooses to play when buying Mint: ``` == Mint AI's turn 4 == Mint AI plays Silver. Mint AI plays...

Fix deadlock when a path is re-locked while the cache is locked globally

4

See comments for details on the deadlock condition. I don't like that it relies on the internal property `_RLock__owner`, but it was the least invasive way I could think to...

The program I'm trying to profile needs command line arguments. It looks like nodeprofile appends argv[2] to the command it tries to run. It'd be nice if it appended the...

Writing enums: pre_assert?

3

I have code like this: ``` #[derive(BinRead, BinWrite, Debug)] #[brw(import(message_type: u8))] enum MessageData { #[br(pre_assert(message_type == 0x0u8))] Nil { }, ... } ``` `bw` / `brw` don't allow `pre_assert` so...