Billy Vong
Billy Vong
Instead of publicly exposing a custom record fn, we'll instead pin specific versions of rrweb via yarn resolutions.
Since I was doing a bunch of cleanup.... thoughts on this @willdurand, @woutervanvliet?
@whywaita Hmm it should be configured -- does this work for you locally? I'm not sure, but it sounds like https://github.com/getsentry/action-github-app-token/pull/17/files#diff-4fab5baaca5c14d2de62d8d2fceef376ddddcc8e9509d86cfa5643f51b89ce3dR70-R73 needs `appId`?
I usually use `lint-staged` + `husky` for my projects and have been pretty happy with it (though I do see the benefits of `git-format-staged` w/ partially staged files)
`tracing/metrics/` tests are flaking a lot, not sure if related to this change specifically
Yes I think this could potentially require SDK work to rewrite URLs, but implementation hasn't really been discussed yet.
We've decided this is nothing something we're going to pursue in the near future. We may revisit this at another time, but for now we're going to close the issue....
Still needs some manual testing but wanted to see if browser tests pass.
Had to increase size limit budget because the `@sentry/browser (incl. Tracing, Replay)` increased from 69899 bytes to 70033 bytes (limit was 70000).
Holding off on upgrading to 2.16.0 due to some potential perf issues