John Billingsley

Results 13 issues of John Billingsley

Thanks @mateczentye for spotting this issue. Incorrect BlanketCutterParallels shape being produced from input parameters. ![Screenshot from 2021-06-25 14-16-20](https://user-images.githubusercontent.com/56687624/123430400-09d01100-d5c0-11eb-995a-9fac2aad2b2f.png) Looks like one point is being missed when creating the shape.

## Proposed changes PR which begins to add option splitting to pf coil casings. ## Types of changes What types of changes does your code introduce to the Paramak? _Put...

This might not be an issue, maybe just an observation - not sure on the intended functionality. Plasma components are not ignored during neutronics simulations if they are in a...

include_neutronics=true/false has been left out of the selective testing matrix because some scripts still have neutronics dependencies which cause their tests to fail in the non-neutronics tests. I.e. the run_scripts.sh...

## Proposed changes Starting PR which updates the method for performing boolean operations of cut, union and intersect. At the moment, the order in which these operations are performed is...

Draft

Currently, the order in which boolean operations are performed is hard coded in the reactor.py class: - Cut - Intersect - Union However, sometimes these operations are not mutable for...

When fillet radius of PortCutterRectangular is not none, the outboard blanket/firstwall components in a BallReactor are not constructed correctly, despite the port cutter itself being constructed correctly. Some port cuts...

bug

The CI github action returns as passed if the dockerfile is successfully built and the tests run. It does not indicate whether tests have passed or failed (only if they...

CI

## Proposed changes PR replacing outdated #610 PR. Adds new BallReactorWithPorts making use of the new port cutters added in #714 . KNOWN ERROR: For some fillet radii, port cutting...