Lars Bilke

Results 38 comments of Lars Bilke

This would be really cool as it would help in using this repo with [CPM](https://github.com/cpm-cmake/CPM.cmake). CPM uses the tags for versioning.

@fishbrainz I can confirm that specifying the `Unity.exe` path in `Projeny.yaml` under `PathVars:` / `UnityExePath:` works when having multiple Unity installations.

Also the reverse, forcing a single library to be downloaded and handled by CPM, would be useful, e.g. `CPM_DOWNLOAD_`.

I also think the setting of threading-related environment variables should be user-configurable. I would like to prepare a PR. @johanneskoester What do you think where this configuration should happen? I...

Yes, the coverage analysis is done per-target. What I do is to create a custom target which runs `ctest`: ``` cmake add_custom_target(ctest COMMAND ${CMAKE_CTEST_COMMAND}) ``` Then I set this up...

We use GTest for unit tests and CTest for end-to-end (executable) testing.

Ah thanks, this is a bug: The script assumes that the second parameter is a valid target as well as a binary located in `CMAKE_BINARY_DIR`: ``` cmake SETUP_TARGET_FOR_COVERAGE(coverageTarget ctestTarget "testResults")...

Maybe you are missing `add_definitions(-fprofile-arcs -ftest-coverage)`?

I have updated the coverage scripts in another project. I will test it there first. - [CodeCoverage.cmake](https://github.com/bilke/ogs/blob/coverage-fixes/scripts/cmake/cmake/CodeCoverage.cmake) - [Invocation of CodeCoverage](https://github.com/bilke/ogs/blob/coverage-fixes/scripts/cmake/Coverage.cmake)

Yes this can be a problem. Unfortunately `add_custom_target` always checks the exit code. Instead you could implement all `COMMAND`-steps in a CMake-script file which is generated at configure time and...