Bikramjeet Singh Vig

Results 10 comments of Bikramjeet Singh Vig

@mbasmanova and @spershin request either of you to please take a look when you get a chance.

@mbasmanova request you to please take another look when you have some free cycles

> Just to confirm, do you mean test coverage with respect to adding a case where final selection is not a superset of sharedSubExpressionRows?

> > Just to confirm, do you mean test coverage with respect to adding a case where final selection is not a superset of sharedSubExpressionRows? > > I'm thinking that...

@Joe-Abraham can you please address the final nits and update the velox documentation at `velox/docs/functions/presto/binary.rst` to clarify this behavior. Thanks!

@rui-mo Thank you for working on adding support for decimal. I'll try to review this PR by tomorrow.

Hi @Real-Chen-Happy , thank you for checking in. The internal issue was caused due to the switch to using Simple function interface instead of vector function. This changed the registration...

Closing this as it is the same as a recently filed issue.