freesurfer
freesurfer copied to clipboard
[BUG] - docker tags are wrong in the README.md and run.py
What version of the bids app were you using?
Version 6 and Version 7 have the same problem.
Describe your problem in detail.
docker pull bids/freesurfer:6
docker pull bids/freesurfer:7
These 2 commands from the README.md won't work as tags have changed to another format such 7-202309
, 7.4.1-202309
, etc.
Same with the warn message when v6 is used.
What command did you run?
See above.
Describe what you expected.
I expected docker/apptainer to pull the container but it didn't.
silly question, do we want those tags to work?
docker pull bids/freesurfer:6
docker pull bids/freesurfer:7
meaning that currently: 7-202309 == 7.4.1-202309
but we may want: 7 == 7-latest == 7-202309 == 7.4.1-202309
From a user perspective, I (naively) assumed that copy/paste would work, then I had to go and find the specific tag on docker hub. IMO, having a working tag (7-latest
) would be a good start then link to docker hub since it is not that obvious which account is the official one to get all the tags.
Note that once default
/latest
is changed to v7, it should be less of a problem.
OK so one PR to update the README for now and we can see for the next release if we want to have more tags.