example
example copied to clipboard
bids-apps
minimize example docker image size
ATM it is whooping 1.13GB so takes time to download it. And then together with #24 it just becomes somewhat disappointing to wait to just get no sensible output.
OK things have gotten worse now
the image is based on neurodocker based build of FSL... and we now have a 15 Go image...
it'd be nice if neurodocker did not create image that crush my will to live
I think the demo bids-app should be a bash script which does something basic and hopefully somewhat useful. Then base image could be literally a few MBs if that. Here is a starting point I thought to pursue at some point but never got to it: https://github.com/yarikoptic/bids-basher/
I like the idea BUT... this repo is also a template got help people get started, so it should at least contains the bids validator.
But I agree that it probably should not have FSL and conda and all the extra fluff the current one has, if only because it makes for a bad template.
Could probably look into how to make the base validator thinner: https://github.com/bids-apps/base_validator/blob/master/Dockerfile
Is bids-validator a requirement for a bids-apps? Although might be a good idea IMHO isn't a requirement really - and in reality I see a lot of uses where people just explicitly disable validate for their fmriprep etc runs
https://bids-apps.neuroimaging.io/dev_faq/#is-it-mandatory-to-first-check-the-dataset-validity-using-the-bids-validator
However... If we want the example repo be an example of good practices, I think it should contain the validator.
Sure people can skip validation, but as an app developer I would then be able to say the behaviors / outputs are much less guaranteed if you skip validation.