Russell Bicknell

Results 136 comments of Russell Bicknell

The builds are now lying to us... They failed, even though it's just the usual Firefox + Selenium and Sauce Connect timeout problems, but they're reporting as having passed.

Note to self: https://github.com/PolymerElements/paper-checkbox/issues/149 Normal `paper-checkbox` also needs to have ink size calculation delayed until focus or down.

ping @notwaldorf

I added https://github.com/PolymerElements/paper-checkbox/compare/3a14255...paper-checkbox-light.

Ok, figured out why the tests were failing in some older browsers: I had used method syntax in an object literal.

@notwaldorf mind taking another look?

I think this has to do with multi-property observers not firing when their dependencies change to undefined: https://github.com/PolymerElements/paper-checkbox/blob/master/paper-checkbox.html#L227.

Yeah, this is the same problem; box dimensions for the checkmark are getting aliased to device pixels.

I agree, but I don't think `:dir()` is supported anywhere except Firefox yet (and prefixed there still). [I added a similar hack to paper-tabs.](https://github.com/PolymerElements/paper-tabs/blob/f0abeab2a174770cf4119272e2a87945b254afa7/paper-tabs.html#L113)