paper-checkbox
paper-checkbox copied to clipboard
PolymerElements
paper-checkbox-light
Diff with master: https://github.com/PolymerElements/paper-checkbox/compare/d38cacc...paper-checkbox-light
Key differences with paper-checkbox:
- No label.
- Does not support use in an iron-form (i.e. doesn't include IronFormElementBehavior).
- Does not support validation (i.e. doesn't include IronValidatableBehavior).
I'll remove the validation tests soon since they no longer apply; the line-height test failing was unexpected though.
paper-checkbox-light needs to include the ink sizing stuff from #135; hopefully that won't slow it down much.
Added noink support and fixed some associated keyboard vs. pointer ripple stuff. Also, I copied over the ink sizing code from #135 and delayed it until the ripple is first created. That would probably be ok to put in regular paper-checkbox also, but I'll save that for a later PR. The diff's a bit gnarlier now, sorry. :/
As usual, Firefox and Selenium have reacted violently; everything seems ok locally though.
The builds are now lying to us... They failed, even though it's just the usual Firefox + Selenium and Sauce Connect timeout problems, but they're reporting as having passed.
@bicknellr Yeah, i merged a PR yesterday that was all green, but the tests were legit broken :sob:
Note to self: https://github.com/PolymerElements/paper-checkbox/issues/149
Normal paper-checkbox also needs to have ink size calculation delayed until focus or down.
minor comments left. If the tests are green and the demos look ok, then LGTM
I added https://github.com/PolymerElements/paper-checkbox/compare/3a14255...paper-checkbox-light.
Ok, figured out why the tests were failing in some older browsers: I had used method syntax in an object literal.
Running into some performance issues with paper-checkbox, what's the status of this?
