Baha Aiman

Results 148 comments of Baha Aiman

Under discussion internally. Will update

Sorry for the very delayed response. Reviewing this

One problem I see with the current design is that it is not extendable. This is what the commit response looks like ``` // The response for [Firestore.Commit][google.firestore.v1.Firestore.Commit]. type CommitResponse...

To minimize friction, consider setting `Allow edits from maintainers` on the PR, which will enable project committers and automation to update your PR.

Found similar request: https://github.com/googleapis/google-cloud-go/issues/1412

> @bhshkh is this something we want to support? Yes

> @bhshkh Thanks for looking at this. > > Regarding the design -- agreed, it would be better if RunTransaction returned both a result (which could hold the CommitTime and...

> @jba @bhshkh Just wondering if we're still moving forward here? Thanks for the modifications! Yes. Waiting on @jba's review.

In Python, projectID and databaseID are optional while creating a new client. This is not the case in Go, a client is tied to particular projectID passed in by the...