Baha Aiman

Results 148 comments of Baha Aiman

Tested with this code: ``` package main import ( "context" "testing" "cloud.google.com/go/bigtable" "cloud.google.com/go/bigtable/bttest" "google.golang.org/api/option" "google.golang.org/grpc" "google.golang.org/grpc/credentials/insecure" ) func TestIssue10688(t *testing.T) { server, err := bttest.NewServer("localhost:0") if err != nil {...

Error from logs: ```go === RUN TestIntegration_AggregationQueries retry.go:44: FAILED after 10 attempts: integration_test.go:1442: "Count success after create with client read time": Mismatch in aggregation result got: map[count:integer_value:0], want: map[count:integer_value:5] ---...

test passed consistently in recent builds. No longer flaky

Error from logs: ``` === RUN TestStreamingPullMultipleFetches ================== WARNING: DATA RACE Read at 0x00c0008aabd0 by goroutine 21722: runtime.raceread() :1 +0x1e cloud.google.com/go/pubsub.(*mockServer).StreamingPull() /tmpfs/src/google-cloud-go/pubsub/mock_test.go:103 +0x70 cloud.google.com/go/pubsub/apiv1/pubsubpb._Subscriber_StreamingPull_Handler() /tmpfs/src/google-cloud-go/pubsub/apiv1/pubsubpb/pubsub.pb.go:9307 +0xe8 google.golang.org/grpc.(*Server).processStreamingRPC() /go/pkg/mod/google.golang.org/[email protected]/server.go:1690 +0x1ffb google.golang.org/grpc.(*Server).handleStream()...

@fsaintjacques Can you share the complete error message that you are seeing in the nightly?

I have created the linked pull request to retry RST stream internal errors.

> @bhshkh is this still wanted/needed? Yes