Ben Perry

Results 30 comments of Ben Perry

Ok, thanks for the info. No plans to update microk8s 1.21's version of containerd?

So the name gets set to the index in [SpecCluster](https://github.com/dask/distributed/blob/8cff8b714cee6396c62707788cdb9899bb2ff330/distributed/deploy/spec.py#L399-L401), but only if there isn't another `name` parameter set in the worker_spec. There could be a parameter for kube-cluster like...

I am using fluentd (td-agent) 1.3.3 Have seen this problem with empty meta/buffer files for a while, and while it no longer crashes fluentd I recently saw an instance of...

I am having the same problem @micheletedeschi Need to use `externalTrafficPolicy: Local` for my clusters, but it seems that Voyager doesn't seem to allow for that with the AWS cloud...

Async for on_finish would be really useful. I am also migrating to async sqlalchemy and need to be able close the session with async. I've seen `loop.add_callback(....)` mentioned a few...

Actually async on_finish would not help my particular issue (although it would still be nice to have). I simulated it by overriding the _execute method and still had the same...

Agreed, finishing async after the request has finished is all around better for prod. I did find it quite frustrating to get DB teardown to work reliably in tests though...

RecursiveCharacterTextSplitter (and others inheriting from TextSplitter) all support custom length functions, and even have the convenient `from_hugginface_tokenizer`/`from_tiktoken_encoder` classmethods. Issue I've noticed with those is that there's no way to take...

`from_toktoken_encoder` and `from_huggingface_tokenizer` classmethods both use a token-based length_function

It does work with any tokenizer. That's why there's a `length_function` kwarg, so you can define the length of a string in any way that you choose. `from_tiktoken_encoder` and `from_huggingface_tokenizer`...