Ben Houston

unreliable benchmarks, please use benchmark.js

1

Quick discussion of the issues here: https://news.ycombinator.com/item?id=16789716

Math.random() is incredibly slow, please do not use it in the middle of benchmarks as it will overpower everything else.

Translucent roughness: Only for specular but not diffuse?

1

The simplified pseudo code for the "translucent" material is this: ``` bsdfs.add( new LambertianReflection( reflectance * diffuse ) ); bsdfs.add( new LambertianTransmission( transmittance * diffuse ) ); var microfacetDistribution =...

This makes no sense so prevent it from happening.

Add a for loop and a sequence example in an unsupported sub folder of examples.

Add an invalid example that uses an unsupported valuetyoename and ensure it fails to pass validation

I am starting to wonder if the main method of evaluating these behavior graphs is actually a stack rather than a work queue. The reason why a stack would be...

Setup package alias so one can import in examples easily.

1

it would be nice to see in the examples this: ``` import { Node } from 'behaviour-graph'; ``` Rather than: ``` import { Node } from '../../../dist/lib/index'; ``` I think...

Enable custom events.

1

It should be possible to listen to any event by a string identifier. And it should be possible to call any custom event by string identifier.

Prove that it can work!