Ben Holmes

Results 105 comments of Ben Holmes

@delucis I think below **Pages** would be best! SvelteKit places "pages" and "endpoints" adjacent to one another, and I agree with that placement given how similar they are. Here's a...

My thoughts haven't changed on this too much! I've sadly had to deprioritize this in favor of other bug and documentation work. Happy to pick this up in the next...

@sarah11918 I totally agree we should document this, especially @delucis' components-as-props snippet above. We've gotten enough support questions on component rendering that warrants some docs. This could slide into the...

@kylebutts Couldn't have written this section better myself 🤩 My only critique is the "This is particularly useful in a dynamic route..." concluding section feels _pretty_ advanced. I might want...

- Astro - https://github.com/withastro/astro - I want to join the members I met at the Maintainer Summit 2022! I also want to learn about improving community engagement and open source...

@wooorm @calebeby No worries! I'll take it from here :) I was able to reproduce Caleb's bug on my end as well when using Shiki Twoslash. Working on a test...

~~@wooorm Hm, I'm getting a `test-coverage` threshold failure after rebasing that I didn't see before. Even reverting the code change, I still get a coverage error locally. Any idea what's...

Alright @wooorm, should be ready to review 👍

@connor-baer thanks for reporting! Yes, this is a known limitation of setting a layout from your frontmatter. I'd definitely recommend your workaround as the way to pass these exports. Also,...

@Princesseuh Yeah that sounds right. I recall seeing this error message on generic types before 🤷