Ben Holmes

Results 105 comments of Ben Holmes

@bluwy Good find! Yes, you're exactly right about how MDX is handled. We leave jSX un-transformed by our Vite plugin, and let Astro's JSX runtime swoop in to compile. I...

Making a note to pull this from the MDX integration! I'll make a separate PR for that when this is merged 👍

Good catch @jackmerrill! Noting a few more details here: - fails on production builds _without_ an SSR adapter as well - occurs on MacOS too - does _not_ occur in...

Thanks for the simple repro @nrgnrg! Can confirm this occurs without the `.local` extension as well.

Yep! Just discovered some added utility from custom Vite modes beyond the `import.meta.env.MODE` too. Namely, allowing custom environment variable extensions like `.env.staging`. Would like to support [everything documented on the...

Thanks for reporting @kylesloper! So far, I've tested: - A React component using any `client:` directive - Hoisted scripts using a standard `script` tag (triggers full-page refresh) - Inline scripts...

Got it, so hoisted and inline scripts specifically. I'm still unable to replicate on my end (tried multiple browsers to be sure), so I'm not sure if this is a...

Thanks for reporting @NotWoods! That _is_ pretty confusing... we've been hard at work on fixing our markdown parser after some recent changes, and I know we haven't been checking for...

Update: can confirm `[...spread].json.ts` _does_ work in SvelteKit SSR. We borrowed their segment logic, so that gives me hope we can resolve this easily!

Thanks for the thorough issue @djmtype! I see [two changes from `beta.42`](https://github.com/withastro/astro/pull/3534) that could be to blame here: - #3537 cc @matthewp - #3492 cc @natemoo-re Can confirm this issue...