Brian Heylin

Hi @alexpovel changing `--rust-query` and related options to multi-modal also sounds reasonable to me. I would simply use `std::Path::is_file` on the option's value and branch from there. I'll get a...

> > One thought: the docs of `std::Path::is_file` mention: > > > When the goal is simply to read from (or write to) the source, the most reliable way to...

> `Value` has similar `is_...` methods as well. Maybe there could be a common `ValueKind` (or similar) used for both, instead of adding this specific `RawKind` (and risking that it...

After the conversation in #62 I'll list some things to consider doing here: - Deprecate any use of `Databsae` in the API Namely the three fns `format_with`, `is_valid_with`, `parse_with` This...

Oh yea for sure I'll take some on :laughing: Otherwise I'd just be complaining and delegating work, and I'm just not ready for a toxic management role yet :laughing: I...

@rubdos I'm taking a look at how we could represent the database and it would help me out if I knew what the minimal API phonenumber needs to support. From...

@rubdos If we use `build.rs` to generate a `databsae.rs` file the existing `Database::regions` HashMap can be converted into a `match` based fn. ```rust fn regions_by_code(code: u16) -> Option { match...

Yea I've made a branch locally to test out the ramifications of replacing the `HashMaps` and as expected it involves a lot of churn. The point of the `match /...

> I thought the whole point here was to get rid of the (de)serialization step? Yes the whole point is to get rid of deserialization, but that cannot be done...

@rubdos I've made a [branch](https://github.com/bheylin/rust-phonenumber/tree/benchmark-database-loading) with benchmarks for loading Metadata using the existing hashmap impl (`benches/load_hashmap_db.rs`) and another benchmark loading a hypothetical static db (`benches/load_static_db.rs`). The static data used in...