Benjamin Hennion
Benjamin Hennion
This PR is a proposed first step towards splitting gui/PageView into a view and a controller. Before this split could be possible, we need to split every tool handler: gui/PageView...
This follows both #4158 and #4137. This PR splits tools/SplineHandler into a view and a controller. It also optimizes (a lot) the rendering costs by only repainting the necessary areas...
Follows #4137. This PR splits tools/StrokeHandler into a View and a Controller. It also optimizes the rendering costs and protects the data with a mutex (see #3579). - [ ]...
From benchmarking cairo (playing around with [this X11 oriented benchmarks](https://openbenchmarking.org/test/pts/cairo-demos)), I could gather the following guidelines for better performances: 1. Avoid using `cairo_image_surface_create()` when creating a mask. It turns out...
This ticket is for discussing View refactor related questions. See also #1795 and #1813 for a previous attempt. The previous PR's #3503 #3985 #4001 #3969 and #3990 created view classes...
**Affects versions :** Latest master 82ab6e3b7 **Describe the bug** The Spline tool does not finalize the current spline when passing to a different page: https://user-images.githubusercontent.com/17818041/178544808-79edcf87-4c10-4c25-b0c1-7b1491049ff2.mp4 I am not sure what...
I (=@Technius) think I found why the copy format is being produced. Here's a simpler crash reproducer: 1. New document with 2 pages. 2. Use the page format dialog in...
Hi every one, This PR fixes #2578. In the current state of things, any new stroke is approximated by a spline and stored as such. The eraser does not yet...
This is a note about tools adopting elements (Eraser, VerticalTool, EditSelection, TextEditor): the behaviour is not homogeneous. Some tools (Eraser & TextEditor) keeps some form of a placeholder in the...
Fix #4897 The issue was: the cairo_pdf_surface was in failed state when cairo_surface_destroy() was calling (internally) cairo_surface_finish(). Indeed, if the outline has links pointing out of the document's bounds (e.g....