Bhavya Agrawal

Results 5 comments of Bhavya Agrawal

I have created a interface ListRepoRequestParams which will contain all the extra parameters as per git provider, each git provider will implement this interface and have different fields in it,...

that's correct, the naming convention and coding style may not match with Go style, as its just a pseudocode to propose our approach, and coming on adding github-only functionality, we...

@bradrydzewski so the aim is that, for github app there is a different end point for listing repos, so we just want to pass a boolean to understand where is...

@bradrydzewski this approach looks good, we can go ahead with this approach, what's say @tphoney? Got your point regarding library, we should expose specific listing method only in github.repositoryService

@bradrydzewski @tphoney, I think we all agree on adding a new method in go-scm and passing a boolean field from delegate to scm service, then scm service will make call...