Bhautik Pipaliya

Results 36 comments of Bhautik Pipaliya

Not sure if I understand this correctly, but why would there be two appended headers? Ideally microservice "a" generates and propagates header to downstream service which downstream service "b" uses...

I feel explicitly setting end time when we are closing the segment would be more appropriate and avoid cases of stale end time values. However, I am not able to...

Hi @dcu , would you mind describing your application setup and provide repro steps ?

Looks like data race is not happening within X-Ray SDK but when this goroutine (https://github.com/aws/aws-xray-sdk-go/blob/master/strategy/sampling/centralized.go#L206) tries to make a http request, this codebase (https://github.com/jarcoal/httpmock/blob/v1/transport.go#L716) from httpmock library updates the value...

Hi @dcu , Sorry for the inconvenience. Currently we don't have support for disabling XRay in XRay Go SDK. We have a pending item in our backlog to support this...

Hi @dcu , That's a good idea I will look more into it to see if we can do that. Also, I'm currently working on disabling XRay Go SDK using...

Hi @dcu , That's good to hear. Would you mind providing more details about http client approach you're talking about ? I want to understand more on that so that...

No, Ideally you shouldn't receive those panics if you have disabled xray. Are you getting those panics ?

Hi @dcu , We still need to prioritize those efforts as you have mentioned (exposing a way to change default client while calling X-Ray API) in comments. I will put...

Yeah I couldn't find the `segment.AddUser()` API in the doc. Can you send me the link? Also, I think right now SDK still lets you set the `User` by retrieving...