Bhautik Pipaliya

Results 36 comments of Bhautik Pipaliya

Yeah that's fair. Right now `xray.BeginSubSegment` API would panic if it does not find it's parent segment. To avoid this with the current state of the SDK you can set...

Hi @mousedownmike, As per my understanding tracing presign call should be a feature request. I think you are receiving this panic because you might have started xray tracing on S3...

Hi @mousedownmike, I was able to repro your issue. Can you provide your source URL of small files in which it's working ? looks like this handler (https://github.com/aws/aws-xray-sdk-go/blob/master/xray/aws.go#L60) receives empty...

Hi @mousedownmike, I think I know why small files are not receiving panic. So basically when file is large S3 APIs upload data in parts and when file is small...

Yeah it is suppressing the panic and continue running your application.

Hi @mousedownmike, Based on my investigation Basically in this call (https://github.com/aws/aws-sdk-go/blob/6627e8938cdef5476dec0510b524258d3bf3983e/service/s3/s3manager/upload.go#L622) getReq call PresignRequest without passing context. since PresignRequest is a sign call it basically calls xray handlers and perform...

That's right. I will add this item in our backlog.

Hi @swoldemi , Thanks for pointing this out. I think this is happening because aws-sdk-go code base creates multiple workers to download the object and calls aws-xray-sdk-go's handlers asynchronously. We...

Hi @corymhall , I think subsegments/segments will use this [method](https://github.com/aws/aws-xray-sdk-go/blob/95821db08ed031914e88b3a7f06c95a943679375/xray/segment.go#L144) to calculate `start_time` in SDK code. So, I think the difference should not be caused by this. Also, I am...

If I understand your use case then you want to see Remote node as a microservice? Also, I think as per current scenario you are doing HTTP call from `fetch...