Bob Green

Results 29 comments of Bob Green

👍 I had to fix this as well. (The travis CI test here fails on a missing panda dep which is unrelated to this PR.)

What needs to happen here is we should move the full documentation out of the README (to something like readthedocs) and the README should get streamlined and include information like...

I have thought about adding the `details` dict as a parameter to some of the other "maybe callables"... However for max_time in particular, I think would be suspect because the...

The `giveup` function could take a details param like the event handlers. The downside is this would break the current contract and I don't think there's a good way to...

Is this just as simple as `await`ing a different sleep function here? https://github.com/litl/backoff/blob/master/backoff/_async.py#L94 if I'm understanding it looks like this would be very easy to accomodate

The README is the docs. It made sense at first to just provide simple examples as the documentation. The simple examples still work, but at this point there's enough details...

For unit testing functions with `requests` calls in them, I recommend `responses` https://github.com/getsentry/responses With backoff in particular, if I expect the call to fail, I usually mock `time.sleep()` to be...

Thank you for the PR. As it turns out, we currently support a `factor` keyword argument on the `backoff.expo` wait generator. Your PR concerns making it available to the `backoff.fibo`...

Thanks for this. I want to play with it a little bit before merging, but I don't see any blockers and the implementation looks clean.

I'm on vacation for the next week. I shoukd be able to get to it when I get back. Ping me again in 1.5 weeks if I haven't. Sorry for...