Ben Pierce
Ben Pierce
MINES appears to have slightly changed their API, we need to skip one more row (to 26) `horizon = pd.read_csv(io.StringIO(res.text), skiprows=26, nrows=360, delimiter=';')`
Thanks, I've implemented a similar function to pull from pvgis and one to calculate directly from a DEM in #1395, all three methods appear to line up well (within ~2...
#1395 doesn't include #1295 but will work along side it. This would give us three methods to calculate horizon: locally using the `horizon` module as well as downloading preprocessed results...
@cwhanse fixed stickler errors, and added underscores for private functions. How should I specify optional dependencies?
Perfect, I added new dependencies to the optional section. I also changed the horizon_map function to accept an array for the DEM rather then a path, as there's a few...
Thanks @cwhanse , went through and made the changes. I did have a question about attributing the code from #758 ; is there a permalink to that pull request if...
> The default 500m was used it is likely to be too small. 10 km might be a better default, but even that will be too small in many locations....
Ok, I added a function to download the DEM tiles. I have it accept a latitude and longitude and download which ever DEM tile that contains it. I made a...
@mikofski yep, as long as the `elevation` argument to horizon_map is a 2D array with values being elevation in meters, it'll work. You'll have to be careful to select the...
Sorry, meant to get back to this sooner. Publication on the DEM method to calculate the horizon map manually is coming along slower then expected, mostly due to difficulties getting...