Benjamin Gilbert

Results 534 comments of Benjamin Gilbert

Seems reasonable. We'd need to define the parent/child relationships for config merging, maybe something like: ``` [root] --- [first child of root] --- [second child of root] --- [third child...

The separate logic would be roughly what we're doing now, so supporting both approaches would only make the code more complicated. The current code works, it's just somewhat intrusive. The...

I've uploaded your 48-bit JXR sample [here](https://openslide.cs.cmu.edu/download/openslide-testdata/Zeiss/Zeiss-5-SlidePreview-JXR.czi).

Probably a good idea to add a Meson build to CI here, since otherwise any future problems will only show up in WrapDB's CI, _after_ a release is tagged.

> Since this is an interface-only library, the files list doesn't actually matter - it's just a hint for IDE file lists and compilers that don't support dependency tracking. It...

There's a backward compatibility concern, though that could potentially be addressed with an `openslide_open2()` that takes a "use new-style rendering" flag. But also, [there's MIRAX](https://lists.andrew.cmu.edu/pipermail/openslide-users/2012-July/000373.html).

See our developer documentation [here](https://openslide.org/docs/devguide/). Code review bandwidth is very limited, so you must carefully follow the guidelines for your changes to be considered.

The sdist's SPDX expression is: ``` LGPL-2.1-only AND blessing AND BSD-1-Clause AND BSD-2-Clause AND BSD-3-Clause AND (BSD-3-Clause OR GPL-2.0-only) AND BSD-3-Clause WITH PCRE2-exception AND BSD-4.3TAHOE AND IJG AND LGPL-2.0-or-later AND...

This is likely due to a combination of a) the Aperio driver not rounding off non-integer downsamples and b) OpenSlide internally splitting large `openslide_read_region()` calls into 4096x4096 chunks.

Apologies, I apparently missed this when it was originally posted. You can upload example slides [here](https://openslide.org/submit/). Please be sure to give us permission to redistribute the slides (provided you're able...