Benjamin Gilbert
Benjamin Gilbert
> But our flow is often used to create a cluster; so we can't default to being driven from an existing cluster. Right, that's the problem: there's no one-size-fits-all solution....
No, I agree that the osmet case shouldn't require the option. But in that case, we don't need `--distro rhcos --stream 4.13` either, since the user has already told us...
If we're going to do https://github.com/coreos/coreos-installer/issues/406, we should do that first.
This would also allow a fully offline / network-not-configured install which still uses an Ignition config URL.
Hmm, I'm not sure that affected users would be paying enough attention to the repo to notice a deprecation + LTS period. How painful would it be to cover this...
There's some discussion [here](https://bugzilla.redhat.com/show_bug.cgi?id=2075049) about not assuming FCOS by default in the `install` command, which is relevant for the `download` command too.
That's `fs::copy`. `io::copy` seems to be doing a [straightforward copy loop](https://github.com/rust-lang/rust/blob/c20d7eecbc0928b57da8fe30b2ef8528e2bdd5be/src/libstd/io/util.rs#L43).
We could pretty easily reimplement `copy()` on top of `copy_n()` from #187.
#290 switched to a `copy()` implementation with a larger buffer.
I spent some more time on this and got nowhere, except to find that #290 was incorrect. https://github.com/coreos/coreos-installer/pull/315 should be more correct, but may not help much either.