Benjamin Gilbert
Benjamin Gilbert
Test case no longer crashes 1.35.4.
One small correction: in the mirrored boot disk case, no partitions are labeled `EFI-SYSTEM`.
Once we have this, we can revert #228.
There could be a race condition when rereading the partition table. In the failing case, if you pass `--preserve-on-error`, do `/dev/loop0p*` devices exist afterward? If not, there might be clues...
No, `--preserve-on-error` is a debugging tool and shouldn't be used for normal operation. > yes, with `--preserve-on-error`, the partitions exist then. To be clear, are you saying that the partitions...
MBR has partition type codes, which are a single byte. Most of the possible codes aren't relevant to us, and all of the relevant ones should have corresponding GPT type...
See previous discussion in [this BZ](https://bugzilla.redhat.com/show_bug.cgi?id=2075049). Quoting myself from comment 9: > Anyone who accidentally installs FCOS is not using the program correctly; they're failing to specify the image they...
> unless we're running on FCOS No, we need to do it everywhere, otherwise we're not actually deprecating the behavior. I'd also argue for advance notice via coreos-installer release notes...
There is also #26. We never added `--distro` because RHCOS doesn't _have_ any reasonable defaults; coreos-installer would need to know what bootimage the cluster was installed from. I don't know...