Benjamin Gilbert
Benjamin Gilbert
Great, I'll credit PreciPoint and rename the files. We should avoid modifying the samples after they are written by your software; otherwise they won't be accurate samples. If current versions...
The files `*.tif-Nb` contain an array of structures, one for each tile in level `N`, in row-major order. Struct members are little-endian. The struct contents seem to be: ``` struct...
Closing as duplicate of #278. See https://github.com/openslide/openslide/issues/278#issuecomment-1237765515 for the current status.
Hi Mathieu, Thanks for the submission, and I apologize for the protracted delay in getting this reviewed. The submitted code is pretty rough, and would need a lot of cleanup...
Review status: all files reviewed at latest revision, 41 unresolved discussions. --- _[src/openslide-decode-dicom.c, line 917 at r1](https://reviewable.io:443/reviews/openslide/openslide/157#-KT7mFyWO-hxEwb2qtqc:-KT7mFyWO-hxEwb2qtqd:b-5yl7qo) ([raw file](https://github.com/openslide/openslide/blob/ac517ffa5030e851d4373e082e4a7f1bc3d37a7f/src/openslide-decode-dicom.c#L917)):_ > ``` C > tiles = di->tiles; > assert( tiles );...
_[src/openslide-decode-dicom.c, line 74 at r1](https://reviewable.io:443/reviews/openslide/openslide/157#-KQJVHommHOnxkjNVQUd:-KT89iIVc0j-CgfmXggJ:by88eh6) ([raw file](https://github.com/openslide/openslide/blob/ac517ffa5030e851d4373e082e4a7f1bc3d37a7f/src/openslide-decode-dicom.c#L74)):_ Previously, bgilbert (Benjamin Gilbert) wrote… > Is this a scenario likely to be encountered by users? If so, we should be able to...
Review status: all files reviewed at latest revision, 40 unresolved discussions. --- _[a discussion](https://reviewable.io:443/reviews/openslide/openslide/157#-KQJRDxZIqlUwwwmpxY8:-KTVzsOzLi6L65A4AqNt:bvuhwmg) (no related file):_ Previously, bgilbert (Benjamin Gilbert) wrote… > I think the major question is whether...
We're not avoiding assertions entirely; we just don't want to crash the whole program on bad input data. You're correct that this should be documented; I've filed [a bug](https://github.com/openslide/openslide.github.com/issues/10). Thanks...
Closing as duplicate of #278. See https://github.com/openslide/openslide/issues/278#issuecomment-1237765515 for the current status.
We have [a few sample files](http://openslide.cs.cmu.edu/download/openslide-testdata/Olympus/) available.