bggardner

Results 41 comments of bggardner

The `socketcanopen` Python module (which I developed independently from this repo), is targeted for creating both masters (including flying masters) and slaves using the same `Node` class. `Nodes` are attached...

Maybe the documentation needs to be clearer, or at least remove the uncommented `network.connect()` example from the README, since it really requires arguments to instantiate a bus, unless one of...

I was writing a post to the message board, but found this issue and decided to post it here instead: Could we consider renaming the BusState enum options according to...

For reference, from [iproute2](https://github.com/shemminger/iproute2/blob/master/ip/iplink_can.c): ``` static const char *can_state_names[CAN_STATE_MAX] = { [CAN_STATE_ERROR_ACTIVE] = "ERROR-ACTIVE", [CAN_STATE_ERROR_WARNING] = "ERROR-WARNING", [CAN_STATE_ERROR_PASSIVE] = "ERROR-PASSIVE", [CAN_STATE_BUS_OFF] = "BUS-OFF", [CAN_STATE_STOPPED] = "STOPPED", [CAN_STATE_SLEEPING] = "SLEEPING" };...

PR #847 contains my suggestions, except for the default value of `BusABC.state` (see [comment](https://github.com/hardbyte/python-can/issues/736#issuecomment-636944755)), which `4.0` would be a good time to change it. Let me know and I can...

The `ERROR-ACTIVE` state is equivalent to "normal". All three `ERROR-*` states mean the bus is "running", but in various states of error, and it could be argued that even `BUS-OFF`...

@hardbyte @felixdivo Now that 4.0 has been released and this was not incorporated :(, what's the plan? Maybe 4.1? I updated PR #847 with upstream so the change can be...

Point of order: The definition of `bus state` in ISO 11898-1 is "one of two complementary logical states: dominant or recessive"...equivalent to a zero or one. Elsewhere in ISO-11898-1, the...

Possibly, but that may be confusing, since the "format" needs to be according to ISO 8601. Values of `$format` could be: * `datetime` (default if not defined) - Full datetime...

An alternative approach (just brainstorming here) is to make `$datatype` simply `iso8601`, and use `$format` to express one of `datetime` (default, maybe), `date`, `time`, `duration`, or `interval`. However, I think...