bfredl
bfredl
special casing `p_ch = 0` seems weird. the goal is to special case it even less, not to add more extra logic. but before doing anything we need to setup...
@chentau Hmm I think it should always call the sort function, it it is not too hard to implement.
somehow the error message does not replace the "search continued at TOP" message, which is something which should happen regardless of 'cmdheight' (and would fix the problem)
@justinmk Some convenience in terms of development cost (converting params and return values, also, documentation Just Works), but we could of course disentangle the generator so it can be used...
can we feature detect and give a more informative error message than ` function not implemented: "C:\Windows\system32\cmd.exe"` perhaps?
@justinmk yes, I think in addition we should collect large-scale statistics of some form. like the total number of cells in various `ui/*_spec.lua` files (which will not fail any build...
merged the changes into https://github.com/neovim/neovim/pull/16396 and began docs/tests
I'll see if there is an easy fix for 0.8, if I remember.
looks alright with TODO comments for things we want to refactor later. Squash of fixup commits?
Not sure, that looks more like a benchmark than a unit test, though my test could be turned more benchmarklike by making sure time is not dominated by verification, either...