bfredl comments

Results 459 comments of


                                            bfredl

fix(ui): send grid_resize events before triggering VimResized

Doing any redraw (including messages) inline in VimResize is a bit sus, but let's merge this for now to avoid the regressions.

[WIP] Add new type '#' (number) for cmdline and use it in get_number

It's because that line is not echoed as a message anymore. It is unrelated to what the test tests (that nvim doesn't crash or behave weirdly with NULL list), so...

[WIP] Add new type '#' (number) for cmdline and use it in get_number

Timer tests are known to be fragile, can ignore them for now. Though with oldtests, at least the ASAN build it looks like it has detected a memory leak.

[WIP] Add new type '#' (number) for cmdline and use it in get_number

Please rebase on master and try again locally, there was a change on master how multiline messages are displayed, this looks like it could be it.

[WIP] Add new type '#' (number) for cmdline and use it in get_number

Seems to work pretty well now. A bit more tests would be good (without ext_cmdline, can be in `ui/input_spec.lua`), for instance: - type number and CR - type number and...

[WIP] Add new type '#' (number) for cmdline and use it in get_number

Actually, `eval/inputlist_spec.lua` would make most sense.

[WIP] Add new type '#' (number) for cmdline and use it in get_number

Probably best to preserve existing behavior of `inputlist()`, so remove the check.

fix: restore original cursor position after :redrawstatus

> From what I understand, Neovim does the redrawing by moving the cursor all around the screen and calling the drawing functions while the cursor is placed at drawing position....

Documentation for libnvim?

It is planned. For 0.6 if not earlier.

Documentation for libnvim?

You can use libnvim today in principle, there is just no distinction between private and public headers (so any internal code change might break your libnvim). The aim for 0.6...