Thomas Beutlich
Thomas Beutlich
> > Blocking accidental merge. Need to wait until master is based on MLS 3.5. > > This has now been changed (to 3.6 to be specific). @dietmarw can you...
> Looks good to me, assuming you looked at all occurrences of `ModelicaAllocateString` and `ModelicaAllocateStringWithErrorReturn` to find all that should be replaced by the new functions. I detected somemore occurrences...
> Not that it matters a whole lot, but I think it would be possible to call `ModelicaError` (which ends with `assert(0)` anyways) as promised in case of error. Thanks....
> (Apart from resolving the conflict) Done.
> @beutlich can you update this from master? I did it like 7 minutes ago, but it is still out of sync _and_ it invalidates my review. Done once again.
> 1. I shall attach the modified script , and generated documents here . wanted to know should I be proceeding with this . Well, as you like. In my...
Given the MSL library comparison of #4300 I see the following classes (besides the ones already documented) that should appear in the release notes (to the best of my knowledge)....
Can you create a draft PR from this branch. Would make life easier for reviewers.
Please note, that I rebased and force-pushed the PR branch.
I agree with your comments @HansOlsson and @henrikt-ma. The main intention of https://github.com/modelica/ModelicaStandardLibrary/pull/4268 was to increase visibility and transparency what's MA and what's third-party as "explicit is better than implicit".